Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with EF 6 #2

Open
scho opened this issue Feb 23, 2014 · 6 comments
Open

Incompatibility with EF 6 #2

scho opened this issue Feb 23, 2014 · 6 comments

Comments

@scho
Copy link

scho commented Feb 23, 2014

Hi,

I've started to play around with the EFRepository. I got some strange errors on my Asp.Net MVC page that it couldn't load the System.Data.Entity.dll.
In the end I found out, that EFRepository doesn't support EF6 and it tries to use EF5. I'm not so familiar with the nuget stuff, but maybe you add that the EntityFramework dependency must not be 6 or newer. Also stating it somewhere in the readme would be awesome.

I my project, I finally ended up fixing the few issues with EF6 by myself (basically all due to namespace changes). If you want I can send you a pull request with my changes and you can release a new version of Repository.EntityFramework.

Anyway, I'm planning on using you library a lot in the future, so far it looks really promising!

Cheers,
scho

scho added a commit to scho/Repository that referenced this issue Mar 1, 2014
@matthewschrager
Copy link
Owner

Hi scho,

Sorry it took me so long to get back to you on this, been real busy the past few days. Yep, I haven't updated EFRepository recently, so I'm not surprised that it doesn't support EF6. A pull request would be great, I'll merge it whenever you send it in :) Thanks!

@scho
Copy link
Author

scho commented Mar 5, 2014

Hi Matthew,

I've sent you a pull request. All I did was fixing the using statements and adding EF6 to packages. I did not run any tests, so you might want to do that.

Another thing: Have you thought about removing the packages folder from the git repository? Adds a lot of noise in my opinion and everyone can get the libs from nuget. Or did I miss anything on that?

@matthewschrager
Copy link
Owner

Awesome, thanks. I'll run some tests later today and merge if everything looks good.

As for the packages folder - you're totally right about this. When I originally created this repo I was A) still getting familiar with using Git, and B) trying to get something up and running quickly, so it's not the cleanest repo in the world. I'll look into blowing away the packages folder too.

Thanks again.

@scho
Copy link
Author

scho commented Mar 5, 2014

This is the .gitignore file that we use:
https://gist.github.com/scho/9367367

At the bottom, there is some stuff that you might not need (Mac OS X, BitTorrent Sync, etc.)

@kellyelton
Copy link

Any progress with this? I'll probably not use it since I didn't really need it and I'm on a schedule here, but I figured I'd poke you about this for people that come along in the future.

Seems pretty nice otherwise.

@rohzart
Copy link

rohzart commented Jan 17, 2015

@kellyelton: You could use @scho's fork (https://github.com/scho/Repository) and apply upgrades missing out on several updates
OR
Upgrading and updating this repo to EF6.x.x itself isn't much of a task: @scho's commit (scho@9c28740) will guide you through.

Further more, if you have the time, you might also be interested in EntityFramework.Extended (https://github.com/loresoft/EntityFramework.Extended)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants