Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter must be an array or an object that implements Countable #3

Closed
rolandtoth opened this issue Mar 15, 2019 · 2 comments
Closed

Parameter must be an array or an object that implements Countable #3

rolandtoth opened this issue Mar 15, 2019 · 2 comments

Comments

@rolandtoth
Copy link

rolandtoth commented Mar 15, 2019 •
edited
Loading

As of PHP 7.2 this error comes up on optimize. I replaced 3 occurrences of count() with wireCount() which fixed it (the excluded one was on line 581).

processwire/processwire-issues#408

I'm not sure this is the best solution though, I don't know if this in earlier PW versions would work or not.
@matjazpotocnik
Copy link
Owner

Hi Roland! I'm on PHP 7.2 and don't see these warnings, but I'm sure they can pop up so in the next version I'll fix this. wireCount() wouldn't work prior to PW 3.0.79 so I'll implement count in Autosmush module itself.

@matjazpotocnik
Copy link
Owner

This is fixed in 1.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rolandtoth @matjazpotocnik