Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defined(ARDUINO_AVR_NANO_EVERY) not work with Nano #30

Open
stef-ladefense opened this issue May 1, 2021 · 3 comments
Open

defined(ARDUINO_AVR_NANO_EVERY) not work with Nano #30

stef-ladefense opened this issue May 1, 2021 · 3 comments
Labels

Comments

@stef-ladefense
Copy link

thank for your library, is very good !

i use Nano, and the precompilator "defined(ARDUINO_AVR_NANO_EVERY)" not work for my arduino ide 1.8.13
the correct syntax is "defined(ARDUINO_AVR_NANO)"

  1. in your exemple "AcceleratedRotator" exst 2 .ino strictely identical

best regard,

Stef

@mathertel
Copy link
Owner

These are 2 completely different boards with different processors:
https://docs.arduino.cc/hardware/nano-every vs. https://docs.arduino.cc/hardware/nano.

@stef-ladefense
Copy link
Author

you did not understand what i mean
in your examples you use
#if defined (ARDUINO_AVR_UNO) || defined (ARDUINO_AVR_NANO_EVERY)
the uno and the nano use the same microcontroller
instead, we should write
#if defined (ARDUINO_AVR_UNO) || defined (ARDUINO_AVR_NANO) || defined (ARDUINO_AVR_NANO_EVERY)

@mathertel
Copy link
Owner

I see, thanks for explaining - I got you wrong.
Can you create a pull request ?

@mathertel mathertel reopened this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants