Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show cover files instead of folder icon for music folders/files #11

Open
RaitaroH opened this issue Jan 3, 2019 · 2 comments

Comments

@RaitaroH
Copy link

RaitaroH commented Jan 3, 2019

So the idea is if a folder has a cover.jpg in it or something like that use that image as an icon instead.

The other option (still pretty cool) is to do the same using embedded covers made with youtube-dl for example. ydl is using ffmpeg as far as I know so it needs some file processing but that would be very cool in my opinion.

@marvinkreis
Copy link
Owner

Interesting idea. If converting jpgs into the right format is fast enough, this might easy to implement as well. I think using embedded images is a bit overkill though, I think this would require caching to be fast enough.

@DaveDavenport
Copy link

I wonder why this does not use rofis build in icon_fetcher.. It is async (uses the threadpool rofi has internally) and you can just pass it a image uri and it will create an icon.

It would make adding this option easy enough. (and async!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants