Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in 'raw': cannot read property 'filter' on undefined in chanModes #472

Open
ra4king opened this issue Jun 25, 2016 · 10 comments
Open

Comments

@ra4king
Copy link

ra4king commented Jun 25, 2016

I received this error after a MODE -b event occurreed. It looks like channel.modeParams[mode] is undefined and the filter function call was made on it on line 300 of irc.js. I'm patching it.

@ra4king
Copy link
Author

ra4king commented Jun 25, 2016

Patch: #473

@sh1omi
Copy link

sh1omi commented Sep 15, 2016

I got the same error when removing quiet mask from a user.
The patch(#473) fixed the issue.

@medikoo
Copy link

medikoo commented Oct 2, 2016

Happened also on my side:

TypeError: Cannot read property 'filter' of undefined
    at chanModes (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:296:37)
    at /home/medyk/irc-notifier/node_modules/irc/lib/irc.js:315:25
    at Array.forEach (native)
    at Client. (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:266:26)
    at emitOne (events.js:82:20)
    at Client.emit (events.js:169:7)
    at iterator (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:842:26)
    at Array.forEach (native)
    at Socket.handleData (/home/medyk/irc-notifier/node_modules/irc/lib/irc.js:837:15)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)

Any chance fix will land soon on npm?

@sh1omi
Copy link

sh1omi commented Oct 2, 2016

@medikoo no one updating the node-irc, you will need to update it urself or download from someone.
You will need to change one line in irc.js https://github.com/sh1omi/node-irc/commit/fd0520a284ed5a13a33d7431d6baae063010fe2d

@medikoo
Copy link

medikoo commented Oct 2, 2016

@sh1omi you're trying to say that this project is no longer maintained? I don't see such info in main documentation.

@sh1omi
Copy link

sh1omi commented Oct 2, 2016

@medikoo yes. :) the last commit is from "Mar 27, 2016".

@medikoo
Copy link

medikoo commented Oct 2, 2016

@martynsmith can you confirm?

@ssachtleben
Copy link

still happening :(

@jimjaeger
Copy link

Hi, the issue still happens. Any outlook for a fix?

@jimjaeger
Copy link

@martynsmith The issue still exists. Can you merge the fix into the master branch? Or what do you need to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants