Improve tile lifecycle determinism #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwilsnd
requested review from
louwers,
adrian-cojocaru,
cgalvan,
alexcristici and
TimSylvester
for more information, see https://pre-commit.ci
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2819-compared-to-main.txt |
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2819-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2819-compared-to-legacy.txt |
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2819-compared-to-main.txt |
|
Looks like it will also fix #2826! |
This was
linked to
issues
Sep 11, 2024
louwers
reviewed
Sep 11, 2024
louwers
reviewed
Sep 11, 2024
louwers
approved these changes
Sep 11, 2024
louwers
reviewed
Sep 12, 2024
TimSylvester
approved these changes
Sep 12, 2024
alexcristici
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some observed behavior in the lifetime of tiles that wasn't initially expected. This PR makes some minor changes to how GeometryTiles update their pending status, to better reflect what the tile is actually doing. One of the more interesting observations is how a tile pyramid's call to
setLayers()can dispatch a task on the worker thread before the tile has even loaded.This PR should address #2807