Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade project to Angular 17 #1379

Open
michaelfaith opened this issue Dec 16, 2023 · 5 comments · May be fixed by #1383
Open

feat: upgrade project to Angular 17 #1379

michaelfaith opened this issue Dec 16, 2023 · 5 comments · May be fixed by #1383

Comments

@michaelfaith
Copy link
Contributor

michaelfaith commented Dec 16, 2023 •
edited
Loading

Now that the Angular 16 PR was merged, thought I'd open this for Angular 17. If you'd like, I can do this one after I get back from the holidays (unless someone gets to it first).
@aram-yesildeniz
Copy link

Hi, in the npm registry there is a version 17.0.1 published --> https://www.npmjs.com/package/angular-oauth2-oidc/v/17.0.1?activeTab=versions
But i cant see any corresponding release/commit/code in this GitHub repository. What does that mean?
Thanks

@jroovers
Copy link

Where is the code for v17 or is it the same as the v16 release?

@michaelfaith michaelfaith linked a pull request Dec 27, 2023 that will close this issue
Open
@stefannikolei
Copy link

@manfredsteyer Can it be that the release for v17 was made from a private branch and was not integrated into master?

@pawelfras
Copy link

Hi all, @manfredsteyer just pushed the commit related to the v17 release: 0211482

@aram-yesildeniz
Copy link

There is still no GitHub Release or Tag for v17...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update project to Angular 17 generalmotors/angular-oauth2-oidc
5 participants
@stefannikolei @michaelfaith @jroovers @pawelfras @aram-yesildeniz