Add session resumption through seeds #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piegamesde
commented
Mar 20, 2022
|
|
||
| ```python | ||
| password = hex(derive(seed, "wormhole:seed:password")) | ||
| nameplate = hex(derive(seed, "wormhole:seed:nameplate")) |
There was a problem hiding this comment.
Using a high entropy nameplate instead of connecting to a mailbox directly solves a lot of the connection issues that I previously had. Notably, multiple concurrent independent connections are possible using the same seed because they will end up in a different mailbox. Also, for the same reason, the error recovery when a mailbox gets "crowded" is a lot quicker.
The current rendezvous server implementation supports this without issues, but nevertheless it may be a good idea to codify this in the protocol that we now rely on this possibility. Edit: added a new commit specifying "high entropy nameplates".
Revert "Client: Add session resumption through seeds" This reverts commit 2779d9143923da75ca1638db294ac993b1fb0ff5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2.
I integrated part of the feedback by focusing more on the client protocol API. Implementation notes have now been moved to a separate sub-section.