Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestors should not undo what the user has just done #7

Open
framespaces-dev opened this issue Aug 11, 2016 · 0 comments
Open

Suggestors should not undo what the user has just done #7

framespaces-dev opened this issue Aug 11, 2016 · 0 comments
Labels
bug
Milestone
Alpha

Comments

@framespaces-dev
Copy link
Collaborator

For example, if you use the eraser to break open a circle to an arc, it should not be immediately snapped back together again.
This is going to require suggestors to be able to look back in history, possibly by changing their signature from (picture, element) to (picture, lastAction), where element == lastAction.result (as per /suggest/index.js). Then, the suggestor could inspect lastAction.prev etc.
@framespaces-dev framespaces-dev self-assigned this Aug 11, 2016
@framespaces-dev framespaces-dev added this to the Alpha milestone Nov 12, 2016
@framespaces-dev framespaces-dev removed their assignment Jan 2, 2017
framespaces-dev added a commit that referenced this issue Apr 30, 2017
@framespaces-dev
Moved change notification out of actions
0afe940 
This is so that change notifications can act on batches, to improve
performance. Also changed suggesters to take the last action, as
required by #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Alpha
Development

No branches or pull requests
1 participant
@framespaces-dev