Skip to content
This repository has been archived by the owner on May 22, 2018. It is now read-only.

swap 1/4 vs started #11

Closed
imylomylo opened this issue May 2, 2018 · 6 comments
Closed

swap 1/4 vs started #11

imylomylo opened this issue May 2, 2018 · 6 comments

Comments

@imylomylo
Copy link

usability wise, using the dexfee paid, bob deposit, alice payment etc. as descriptors is nicer than 1/4. adds to education for some.

not necessarily using "bob deposit" but some other phrase. my 2c.

now, gsad :)

@lukechilds
Copy link
Owner

I'm not sure it is. If you're not familiar with the steps and your trade is on bobdeposit most users will have no idea what that means or how far through it is. Everyone understands what 2/4 means.

Remember this is supposed to be grandma friendly, we're trying to be usable for technically inept users.

That said, you raise a good point about adding education. I'm currently working on the "View" modal to view more info on a swap. This will contain more detailed info such as which AS TXs you have completed and which are pending. The name, the amount, the TXID etc.

So I think this will be a good compromise of obvious data in the main UI, but more complex data in the modal for advanced users or people who want to understand what's going on.

@jansako
Copy link

jansako commented May 2, 2018

It could also be done by a tooltip popping up when the user hovers over the status.

Tooltips are great for educating users without cluttering the UI.

On a related note, maybe having a timer on the 'pending' that would tell the user how long before status will change to 'failed' (I suppose 'expired' would be more appropriate once jl implements the error codes :-)

@lukechilds
Copy link
Owner

On a related note, maybe having a timer on the 'pending' that would tell the user how long before status will change to 'failed' (I suppose 'expired' would be more appropriate once jl implements the error codes :-)

That would be great but reliably calculating when a trade will be expired is not a simple task:

jl777/SuperNET#745
jl777/SuperNET#756
jl777/SuperNET#775

@imylomylo
Copy link
Author

imylomylo commented May 2, 2018 via email

@lukechilds
Copy link
Owner

lukechilds commented May 3, 2018

The main issue is real estate, we have limited space in the swaps list on some screen sizes so we need to make sure it displays well on all screens.

Let me get the view swap modal pushed and then we can review this and see if we can make it more obvious.

@sindresorhus
Copy link
Sponsor Contributor

We now show the full names of the steps if you click the "View" button to see swap details.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants