Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate committing EVM state only once per block #1568

Open
pathornteng opened this issue Nov 4, 2019 · 1 comment
Open

Investigate committing EVM state only once per block #1568

pathornteng opened this issue Nov 4, 2019 · 1 comment
Assignees
@pathornteng
Labels
performance

Comments

@pathornteng
Copy link
Contributor

pathornteng commented Nov 4, 2019 •
edited
Loading

Currently, loomchain commits EVM state right after each EVM tx is processed. Committing EVM state is an expensive process and costing around 60% of tx processing time. loomchain should be able to use the same EVM state object for multiple EVM txs and only commit it once at block commit.

We also should take a look at this Go Ethereum state commit improvement ethereum/go-ethereum@223b950#diff-19b2c4499088b23ccb40eedb26c42e68.

This issue can be started after this PR is merged #1532
@pathornteng pathornteng self-assigned this Nov 4, 2019
@pathornteng pathornteng mentioned this issue Nov 6, 2019
Merged
4 tasks
@pathornteng
Copy link
Contributor Author

Update: this commit ethereum/go-ethereum@223b950#diff-19b2c4499088b23ccb40eedb26c42e68 won't improve our chain as EVM state is committed only once per block. It also requires a feature flag to activate. So leave it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pathornteng pathornteng

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pathornteng