Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_getTransactionReceipt & eth_getTransactionByHash resolve caller address differently #1559

Open
enlight opened this issue Oct 29, 2019 · 1 comment
Open

eth_getTransactionReceipt & eth_getTransactionByHash resolve caller address differently #1559

enlight opened this issue Oct 29, 2019 · 1 comment
Assignees
@Sriep
Labels
bug Something isn't working

Comments

@enlight
Copy link
Contributor

enlight commented Oct 29, 2019

eth_getTransactionReceipt and eth_getTransactionByHash (as well as eth_getBlockByNumber among others that contain full tx details) return mismatched from addresses for EVM calls/deploys. The from on the tx receipt is the local address, while the from on the tx object is the eth address, these should be consistent everywhere. So we need to make sure that eth addresses are mapped to a local address in eth_getTransactionByHash, eth_getBlockByNumber etc.
@enlight enlight added the bug Something isn't working label Oct 29, 2019
@atchapcyp atchapcyp self-assigned this Oct 30, 2019
@enlight enlight assigned Sriep and unassigned atchapcyp Nov 22, 2019
@Sriep Sriep mentioned this issue Nov 25, 2019
Open
4 tasks
@Sriep
Copy link
Contributor

Sriep commented Nov 26, 2019

Addressed in #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sriep Sriep

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enlight @Sriep @atchapcyp