Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add weight device_class to weight sensor #76

Open
1 task done
kaizersoje opened this issue Jan 4, 2023 · 3 comments
Open
1 task done

Add weight device_class to weight sensor #76

kaizersoje opened this issue Jan 4, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@kaizersoje
Copy link
Contributor

kaizersoje commented Jan 4, 2023

Select Add-On (place a lowercase x for the relevant add-on)

  • Xiaomi Mi Scale

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.
New weight device class has been added in HA Core 2023.1.x. URL
Could you add this device_class to the weight sensors?

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@kaizersoje kaizersoje added the enhancement New feature or request label Jan 4, 2023
@lolouk44
Copy link
Owner

lolouk44 commented Jan 5, 2023

Thanks. I'll probably wait a bit as this would be a breaking change, forcing all users to upgrade HA.

I'll keep this open in the meantime

@kaizersoje
Copy link
Contributor Author

Sorry, my bad. It was added in 2022.10 change

All changes in 2022.10

@lolouk44
Copy link
Owner

lolouk44 commented Jan 5, 2023

Hey @kaizersoje, I looked into this again and I'm not sure what the benefits would be.
Regardless you can add this yourself to your sensor config if manually configured. If using MQTT Auto-Discovery I'll look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants