Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't extend PublishModule #156

Closed
lefou opened this issue May 30, 2024 · 0 comments · Fixed by #158
Closed

Don't extend PublishModule #156

lefou opened this issue May 30, 2024 · 0 comments · Fixed by #158
Assignees
@lolgab

Comments

@lefou
Copy link
Collaborator

lefou commented May 30, 2024

I think we could drop the need to be a PublishModule, since we already have all targets to configure the jars to compare. Being a PublishModule just brings some nice defaults, but we could match this dynamically (like I did for the scalaBinVersion task in PR #155). That way, users can use MiMa in arbitrary modules, without messing with mill __.publish targets.

Originally posted by @lefou in #155 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolgab lolgab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make MiMa not extend PublishModule lolgab/mill-mima
2 participants
@lefou @lolgab