Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues around method option #57

Open
TheVastyDeep opened this issue Sep 30, 2020 · 0 comments
Open

Issues around method option #57

TheVastyDeep opened this issue Sep 30, 2020 · 0 comments

Comments

@TheVastyDeep
Copy link

TheVastyDeep commented Sep 30, 2020 •
edited
Loading

The method option has :required => true, :default => 'SHA1'. Since there is a default the user is not required to set it, and it is confusing that the documentation appears to say that they are.

Is it time to move the default from SHA1 to SHA256?

MD5 was broken 20 years ago, and SHA1 is clearly broken in 2020. Should these be deprecated and support removed in a future version?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheVastyDeep