Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support max length setting on exception message (to be used with ShortenedThrowableConverter.maxLength) #1013

Open
gauravsaralMs opened this issue Mar 21, 2024 · 3 comments
Labels
help-wanted Contributions welcome type/enhancement

Comments

@gauravsaralMs
Copy link

Is your feature request related to a problem? Please describe.
Currently if ShortenedThrowableConverter.maxLength is set to any value (say 1000) then that includes the exception message as well as stack trace length.
In case someone adds a large/dynamic exception message then it is possible that the whole stack trace is lost.

Describe the solution you'd like
proposal is to include a setting ShortenedThrowableConverter.maxErrorMessageLength which can be used to limit the length of error message being included.
So with maxErrorMessageLength set as 100 and maxLength set as 1000 it can be guaranteed that 900 limit will be used for stack traces.

Describe alternatives you've considered
N/A

Additional context
N/A

@gauravsaralMs
Copy link
Author

@philsttr gentle ping to please take a look at this issue.

I am open to contributing this feature but want to confirm that this feature sounds good be added.

@philsttr philsttr added the help-wanted Contributions welcome label Jul 27, 2024
@philsttr
Copy link
Collaborator

Sounds good to me. Contributions welcome

@a1shadows
Copy link

Can I take this up if no one else is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Contributions welcome type/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants