Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced isKinematic = true when setPosition/setQuaternion #80

Open
wmcmurray opened this issue Nov 5, 2018 · 0 comments
Open

Forced isKinematic = true when setPosition/setQuaternion #80

wmcmurray opened this issue Nov 5, 2018 · 0 comments

Comments

@wmcmurray
Copy link

Hey, I just spent a long time trying to understand why my dynamic meshes where not moving at all, until I found this :

setPosition: function(pos){
this.newPosition.copy( pos ).multiplyScalar( this.invScale );
this.controlPos = true;
if( !this.isKinematic ) this.isKinematic = true;
},
setQuaternion: function(q){
this.newOrientation.set(q.x, q.y, q.z, q.w);
this.controlRot = true;
if( !this.isKinematic ) this.isKinematic = true;
},

Those two methods have this line of code at the end :

if( !this.isKinematic ) this.isKinematic = true;

which makes no sense to me, how changing the position of a dynamic object automatically makes it of kinematic type ?? 🤔

This has been commited 2 years ago, it's surprising that it has not been spotted before, so maybe I misunderstood something ?

Thanks 🙂 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant