Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedback from Jonas #18

Open
7 of 8 tasks
MalikaIhle opened this issue Sep 16, 2024 · 0 comments
Open
7 of 8 tasks

feedback from Jonas #18

MalikaIhle opened this issue Sep 16, 2024 · 0 comments

Comments

@MalikaIhle
Copy link
Member

MalikaIhle commented Sep 16, 2024

  • Project Setup: "How do you know you are allowed to copy, edit, and share the two files linked above?" TBH I wouldn't know how to answer the question here because I couldn't find any copyright info in the files. What do you expect here?
  • Choose a License: why do you recommend Apache 2.0 over MIT? Just curious as e.g. for tidyverse/posit I often see MIT
  • Choose a License: "Note, however, that the copyleft licenses we discuss here do not mandate sharing. Copyleft (and attribution) clauses are only triggered if the work is shared (Creative Commons 2015)." I think here some more explanation would be good. E.g.: "[...] is shared (Creative Commons 2015), but not if you only use it internally." Or even a bit more? I know that the focus is on sharing your work, but I think it's good to know that the restrictions are not given if you only use it internally.
  • Choose a License: I think a short section about who can exploit the work should be added. As far as I understand in some jurisdictions the copyright is automatically transferred to the employer, while that is not possible in Germany (https://www.lexology.com/library/detail.aspx?g=a8cba6b5-19ce-429b-9bcb-f1625f3b165c). However, the employer has the right to exploit the work, and therefore one should theoretically consult with a supervisor which license to use. What do you think?
  • Choose a License: "Note 4: Using REUSE to Record Licenses": is the pip install reuse into the system python installation good practice? I'm not a python guy, just caught my eye
  • Choose a License: typo: "If you want to indicate the license for all files in a particular folder, you can create a filed"
  • Choose a License: "sui generis" is often not italicized
  • Make a README: Citation: maybe also mention CFF (https://citation-file-format.github.io/) as an alternative?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant