Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect to pulseaudio timeout #657

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

zsien
Copy link
Member

@zsien zsien commented Sep 24, 2024

Waiting for the services to active

Bug: https://pms.uniontech.com/bug-view-275185.html

@zsien zsien force-pushed the zs/fix/audio branch 2 times, most recently from 389fd37 to 755d605 Compare September 25, 2024 05:19
@zsien zsien requested a review from a team September 25, 2024 05:21
Copy link

TAG Bot

TAG: 6.0.46
EXISTED: no
DISTRIBUTION: unstable

  * fix: connect to pulseaudio timeout
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • startAudioServer函数中,wg.Add(1)wg.Done()的使用可能会导致竞态条件,因为wg.Done()if value == "active" && !actived条件成立时被调用,而wg.Add(1)if state != "active"条件不成立时被调用。这可能会导致wg.Wait()state变为"active"时立即返回,而没有等待wg.Done()完成。
  • serverSystemdUnit.InitSignalExt(sigLoop, true)的调用可能不会按预期工作,因为serverSystemdUnit.Unit().ActiveState().ConnectChanged的连接应该已经通过serverSystemdUnit.InitSignalExt初始化。
  • logger.Warning("failed to get audio server active state", err)可能会导致日志输出错误,因为err可能不是预期的错误类型。
  • wg.Wait()在循环中调用可能会导致程序在等待事件完成时无限期地阻塞。

是否建议立即修改:

@zsien
Copy link
Member Author

zsien commented Sep 25, 2024

/integrate

Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2037
PrNumber: 2037
PrBranch: auto-integration-11026869308

Copy link

@ArchieMeng ArchieMeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants