Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indentation of bin/proc files #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oglinuk
Copy link
Contributor

@oglinuk oglinuk commented Jan 1, 2022

Went through all files in bin/proc and cleaned up the indentation. The style is following the Linux kernel developments coding style (https://www.kernel.org/doc/html/v4.10/process/coding-style.html). For the most part I left the comments, as I don't want to remove anything that might be useful. The comments do need to be cleaned up though. If the changes to bin/proc are acceptable, I will go ahead and fix the entire repositories indentation. This resolves issue #48

Went through all files in `bin/proc` and cleaned up the indentation. The
style is following the Linux kernel developments coding style
(https://www.kernel.org/doc/html/v4.10/process/coding-style.html). For
the most part I left the comments, as I don't want to remove anything
that might be useful. The comments do need to be cleaned up though.
@linleyh
Copy link
Owner

linleyh commented Jan 1, 2022

Ah, I didn't think of the formatting of the in-game processes. I'm not sure about updating these - the current formatting should be mostly consistent with the way the autocoder formats its output, and it would be confusing to have different styles there. Each of the /proc files would need to be manually tested as well, which would have to be a pain. Also, I'm afraid that I find that indentation style much harder to follow than the style where the braces always go on the next line.

@oglinuk
Copy link
Contributor Author

oglinuk commented Jan 1, 2022

Ah gotcha, I started with the in-game processes first since that is what is edited most. I did test each file in-game, though not down to each part, and all files are working with the new indentation. I will agree there were some places where the indentation is harder to follow, but that also might have been my doing when breaking up a long statement like in the case COM_FRIEND block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix indentation
2 participants