Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onlyoffice rework #650

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

onlyoffice rework #650

wants to merge 55 commits into from

Conversation

ericlinagora
Copy link
Contributor

@ericlinagora ericlinagora commented Sep 18, 2024 •
edited
Loading

#525 #515 #548 #523

This is a rewrite to have a more robust connexion with only office, recovering forgotten files, handling editing sessions as global locks, that kind

ericlinagora and others added 30 commits August 25, 2024 22:26
@ericlinagora
🚧 WIP: backend: beginnings of a transactional editing for plugins (#525)
688217d
@shepilov @ericlinagora
🚧Changing file identifier with editing_session_id
ca3ebcc
@ericlinagora
🚨🩹 ooconnector: pass linter, fix bug where ignored promises in poller…
3c156c4 
… caused crash (#525)
@shepilov @ericlinagora
💄Added user friendly error page instead of JSON response
7941ba2
@shepilov @ericlinagora
✨Added editing session key to the connector services
d94ec46
@ericlinagora
✨ ooconnector: poll forgotten files, wip: extract code from oocallbac…
0914db9 
…k to call here (#525)
@shepilov @ericlinagora
🐛Fixed document identifier for OnlyOffice in view mode
a692eab
@ericlinagora
🚧 ooconnector: show forgotten files in health endpoint for debugging (#…
b6be90f 
…525)
@shepilov @ericlinagora
✨Added support of the session editing key for the OnlyOffice connector
c66123f
@ericlinagora
♻️ backend: move editing_session_key generation and parsing to specif…
3b81a21 
…ic implementation (#525)
@ericlinagora
✅♻️🩹 backend: add company_id to editing_session_key (#525)
9b0dcc1
@ericlinagora
✨ backend: Add callback to application to check editing key status (#525
483b1b0 
)
@ericlinagora
♻️ backend: adding freeform instanceid to identify multiple instances…
afe6562 
… of plugin (#525)
@ericlinagora
♻️ oo-connector: refactored router system to something more coherent (#…
9bc9dca 
…525)
@ericlinagora
💄 oo-connector: Fixed error page to show 500, correct e-mail, removed…
996c7a9 
… GA (#525)
@ericlinagora
🐛 backend: fix bug with postgres support when uploading files
66525d7
@ericlinagora
🔀 Merge branch 'postgres-support-fix' into 525-515-548-523-onlyoffice…
93351d5 
…-rework
@ericlinagora
✨ backend: Adding support for select based on null values and negation (
53b34a0 
#525)
@ericlinagora
✨ backend cli: add editing_session list viewer command (and minor ins…
1e16e17 
…tanceId fixes) (#525)
@ericlinagora
🐛 ooconnector: minor error page dark mode (#525)
22f04a5
@ericlinagora
🩹 ooconnector: using user token for post to backend (#525)
1d81c94
@ericlinagora
✨ ooconnector: callback command retreival system (#525)
5cf1fa5
@ericlinagora
♻️ ooconnector: routing refactor (#525)
87d0de9
@ericlinagora
✨ cli: improve editing session listing (#525)
ee63bec
@ericlinagora
🩹 backend,oo: small fixes, related to instance id (#525)
b8814c0
@ericlinagora
♻️🩹🚨 backend,oo: remove company_id when key available and minor clean…
2eb6f73 
…up (#525)
@ericlinagora
♻️ cli: better information about file history and key (#525)
c9db0bf
@ericlinagora
♻️ backend,oo: split endEditing into add version and actual end, via …
816fb58 
…"updateEditing" (#525)
@ericlinagora
♻️ oo-connector: wip on callbacks and key reactions, and minor cleanup (
7b78c32 
#525)
@ericlinagora
🔀 Merge remote-tracking branch 'origin/main' into 525-515-548-523-onl…
15ca46b 
…yoffice-rework
@ericlinagora ericlinagora marked this pull request as ready for review September 18, 2024 22:59
@ericlinagora ericlinagora changed the title WIP (no review yet please): onlyoffice rework onlyoffice rework Sep 18, 2024
@ericlinagora ericlinagora force-pushed the 525-515-548-523-onlyoffice-rework branch from 118e6a0 to c239843 Compare September 18, 2024 23:03
@ericlinagora
Copy link
Contributor Author

This is a bit of an express PR, so documentation will come later. As to testing most would require emulating the only office document server and the connector...

@ericlinagora ericlinagora force-pushed the 525-515-548-523-onlyoffice-rework branch from 8f5a6c6 to 5285de4 Compare September 19, 2024 17:34
@ericlinagora ericlinagora force-pushed the 525-515-548-523-onlyoffice-rework branch from 279694a to e2ec557 Compare September 27, 2024 10:43
@ericlinagora ericlinagora force-pushed the 525-515-548-523-onlyoffice-rework branch from e2ec557 to 630d266 Compare September 27, 2024 10:44
This was linked to issues Sep 28, 2024
[BUG] Rename folder or file with space only in name #660
Open
Too many version for the file are created during the file editing in the onlyOffice #525
Open
Whe I edit document in OnlyOffice I don't see the changes made by another people and my changes are overrriden #523
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ericlinagora @shepilov