Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-2143 Open composer into a new tab #2896

Open
wants to merge 10 commits into
base: refactor
Choose a base branch
from
Open

TF-2143 Open composer into a new tab #2896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b9997db
TF-2143 Add abstraction storeComposedEmail & getComposedEmail method
dab246 May 28, 2024
2bba21e
TF-2143 Implement store & get composed email in datasource
dab246 May 28, 2024
9ef73cd
TF-2143 Implement store & get composed email in interactor
dab246 May 28, 2024
5c51789
TF-2143 Show `Open new tab` button in composer
dab246 May 28, 2024
47e2937
TF-2143 Handle store composed email to local storage browser when cli…
dab246 May 28, 2024
acd9121
TF-2143 Handle restore currently composer when open new tab
dab246 May 28, 2024
dbad455
TF-2143 Implement delete composed email on local storage browser afte…
dab246 May 28, 2024
d8655f1
TF-2143 Write unit test for composer controller
dab246 May 29, 2024
5bb9d58
TF-2143 Automatically create tags for `To/Cc/Bcc` input when clicking…
dab246 May 31, 2024
88dea2a
TF-2143 Handle open composer into new tab when have `Attachments/Inli…
dab246 Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/features/composer/data/repository/composer_repository_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ class ComposerRepositoryImpl extends ComposerRepository {
if (createEmailRequest.inlineAttachments?.isNotEmpty == true) {
final tupleContentInlineAttachments = await _replaceImageBase64ToImageCID(
emailContent: emailContent,
inlineAttachments: createEmailRequest.inlineAttachments!
inlineAttachments: createEmailRequest.inlineAttachments!,
isCaching: createEmailRequest.isCaching
);

emailContent = tupleContentInlineAttachments.value1;
Expand All @@ -77,12 +78,14 @@ class ComposerRepositoryImpl extends ComposerRepository {

Future<Tuple2<String, Set<EmailBodyPart>>> _replaceImageBase64ToImageCID({
required String emailContent,
required Map<String, Attachment> inlineAttachments
required Map<String, Attachment> inlineAttachments,
bool isCaching = false
}) {
try {
return _htmlDataSource.replaceImageBase64ToImageCID(
emailContent: emailContent,
inlineAttachments: inlineAttachments);
inlineAttachments: inlineAttachments,
isCaching: isCaching);
} catch (e) {
logError('ComposerRepositoryImpl::_replaceImageBase64ToImageCID: Exception: $e');
return Future.value(
Expand Down
7 changes: 3 additions & 4 deletions ...store_email_inline_images_interactor.dart → ...nvert_image_cid_to_base64_interactor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import 'package:dartz/dartz.dart';
import 'package:tmail_ui_user/features/composer/domain/state/restore_email_inline_images_state.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/repository/composer_cache_repository.dart';

class RestoreEmailInlineImagesInteractor {
RestoreEmailInlineImagesInteractor(this._composerCacheRepository);
class ConvertImageCIDToBase46Interactor {
ConvertImageCIDToBase46Interactor(this._composerCacheRepository);

final ComposerCacheRepository _composerCacheRepository;

Expand All @@ -17,8 +17,7 @@ class RestoreEmailInlineImagesInteractor {
}) async* {
try {
yield Right(RestoringEmailInlineImages());

final emailContent = await _composerCacheRepository.restoreEmailInlineImages(
final emailContent = await _composerCacheRepository.convertImageCIDToBase64(
htmlContent,
transformConfiguration,
mapUrlDownloadCID);
Expand Down
21 changes: 11 additions & 10 deletions lib/features/composer/domain/usecases/save_composer_cache_on_web_interactor.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import 'package:jmap_dart_client/jmap/account_id.dart';
import 'package:jmap_dart_client/jmap/core/user_name.dart';
import 'package:tmail_ui_user/features/composer/domain/repository/composer_repository.dart';
import 'package:tmail_ui_user/features/composer/presentation/model/create_email_request.dart';
import 'package:tmail_ui_user/features/composer/presentation/model/screen_display_mode.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/data/model/composer_cache.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/repository/composer_cache_repository.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/state/save_composer_cache_state.dart';

Expand All @@ -21,19 +21,20 @@ class SaveComposerCacheOnWebInteractor {
Future<Either<Failure, Success>> execute(
CreateEmailRequest createEmailRequest,
AccountId accountId,
UserName userName,
{required ScreenDisplayMode displayMode}
UserName userName
) async {
try {
final emailCreated = await _composerRepository.generateEmail(createEmailRequest);
final identity = createEmailRequest.identity;
final composerCache = ComposerCache(
email: emailCreated,
identity: createEmailRequest.identity,
isRequestReadReceipt: createEmailRequest.isRequestReadReceipt,
displayMode: createEmailRequest.displayMode,
);
await _composerCacheRepository.saveComposerCacheOnWeb(
emailCreated,
accountId: accountId,
userName: userName,
displayMode: displayMode,
identity: identity,
readReceipentEnabled: createEmailRequest.isRequestReadReceipt);
composerCache,
accountId,
userName);
return Right(SaveComposerCacheSuccess());
} catch (exception) {
return Left(SaveComposerCacheFailure(exception));
Expand Down
10 changes: 8 additions & 2 deletions lib/features/composer/presentation/composer_bindings.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import 'package:tmail_ui_user/features/composer/data/repository/composer_reposit
import 'package:tmail_ui_user/features/composer/data/repository/contact_repository_impl.dart';
import 'package:tmail_ui_user/features/composer/domain/repository/composer_repository.dart';
import 'package:tmail_ui_user/features/composer/domain/repository/contact_repository.dart';
import 'package:tmail_ui_user/features/composer/domain/usecases/convert_image_cid_to_base64_interactor.dart';
import 'package:tmail_ui_user/features/composer/domain/usecases/create_new_and_save_email_to_drafts_interactor.dart';
import 'package:tmail_ui_user/features/composer/domain/usecases/create_new_and_send_email_interactor.dart';
import 'package:tmail_ui_user/features/composer/domain/usecases/download_image_as_base64_interactor.dart';
import 'package:tmail_ui_user/features/composer/domain/usecases/restore_email_inline_images_interactor.dart';
import 'package:tmail_ui_user/features/composer/domain/usecases/save_composer_cache_on_web_interactor.dart';
import 'package:tmail_ui_user/features/composer/domain/usecases/upload_attachment_interactor.dart';
import 'package:tmail_ui_user/features/composer/presentation/composer_controller.dart';
Expand Down Expand Up @@ -45,6 +45,7 @@ import 'package:tmail_ui_user/features/mailbox/data/repository/mailbox_repositor
import 'package:tmail_ui_user/features/mailbox/domain/repository/mailbox_repository.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/repository/composer_cache_repository.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/remove_composer_cache_on_web_interactor.dart';
import 'package:tmail_ui_user/features/mailbox_dashboard/domain/usecases/save_composer_cache_to_local_storage_browser_interactor.dart';
import 'package:tmail_ui_user/features/manage_account/domain/usecases/get_all_identities_interactor.dart';
import 'package:tmail_ui_user/features/manage_account/presentation/profiles/identities/identity_interactors_bindings.dart';
import 'package:tmail_ui_user/features/offline_mode/manager/new_email_cache_manager.dart';
Expand Down Expand Up @@ -209,8 +210,12 @@ class ComposerBindings extends BaseBindings {
Get.find<MailboxRepository>(),
Get.find<ComposerRepository>(),
));
Get.lazyPut(() => RestoreEmailInlineImagesInteractor(
Get.lazyPut(() => ConvertImageCIDToBase46Interactor(
Get.find<ComposerCacheRepository>()));
Get.lazyPut(() => SaveComposerCacheToLocalStorageBrowserInteractor(
Get.find<ComposerCacheRepository>(),
Get.find<ComposerRepository>(),
));

IdentityInteractorsBindings().dependencies();
}
Expand All @@ -236,6 +241,7 @@ class ComposerBindings extends BaseBindings {
Get.find<GetAlwaysReadReceiptSettingInteractor>(),
Get.find<CreateNewAndSendEmailInteractor>(),
Get.find<CreateNewAndSaveEmailToDraftsInteractor>(),
Get.find<SaveComposerCacheToLocalStorageBrowserInteractor>(),
));
}

Expand Down
Loading
Loading