New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support data downloading/uploading #49

Open

jeserkin opened this issue Apr 7, 2021 · 0 comments

Collaborator

jeserkin commented Apr 7, 2021

Mainly issue is regarding -> https://jmap.io/spec-core.html#binary-data
In session response we have a bunch of different URLs including

{
  "downloadUrl": "http://localhost/download/{accountId}/{blobId}/?type={type}&name={name}",
  "uploadUrl": "http://localhost/upload/{accountId}"
}

So as far as I can tell, what can be done on jmap-client-ts level is:

return URL with accountId replaced, since it is present in session response as well.
For upload, there could be a type definition for response as mentioned here https://jmap.io/spec-core.html#uploading-binary-data
Also for upload, there could be an entire method present, that would allow data upload. End-user should provide only body value, e.g. Blob

If there are any other suggestions on how to proceed with it, then I would love to hear about it.

The text was updated successfully, but these errors were encountered:

jeserkin mentioned this issue

Separate low and high level API #46

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment