Clean identity server #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .get('longTermKeypairs', ['public'], { | ||
| public: publicKey | ||
| }) | ||
| .then((rows) => { | ||
| if (rows.length === 0) { | ||
| send(res, 200, { valid: false }) | ||
| } else { | ||
| // TO DO : ensure that the pubkey only appears one time | ||
| // TODO : ensure that the pubkey only appears one time |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
guimard
reviewed
Aug 16, 2024
| @@ -10,7 +10,7 @@ | |||
| "database_ssl": false, | |||
| "database_user": "", | |||
| "database_vacuum_delay": 3600, | |||
| "federated_identity_services": null, | |||
| "federated_identity_services": ["-invalid.host.com"], | |||
There was a problem hiding this comment.
Why this change ? null means no fd service
There was a problem hiding this comment.
i made this change to have a better test coverage - invalid host names are filtered out from the config when creating the MatrixIdentityServer
There was a problem hiding this comment.
Not the good file. Here is the default config, change this into a test config file
| if (err) { | ||
| reject(err) | ||
| } | ||
| reject(err) |
There was a problem hiding this comment.
More short version : stmt.finalize(reject)
h1ppox99
force-pushed
the
clean-identity-server
branch
from
711ea7d
to
1ff0e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conclusion of the cleaning :
1 - it is necessary to tackle #61 - key management is not good for the moment
2 - maybe a deep review of cron tasks will be needed (not enough test coverage for the moment)