Refactor: network.YAML → network.Config #2667
Open
+56
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because YAML is just the serialization format, and not what the data is used for. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
refactor-network-yaml
branch
from
0aa670b
to
c921b1e
Compare
AkihiroSuda
reviewed
Sep 29, 2024
| @@ -353,12 +353,12 @@ func attachNetwork(driver *driver.BaseDriver, vmConfig *vz.VirtualMachineConfigu | |||
| if runtime.GOOS != "darwin" { | |||
| return fmt.Errorf("networks.yaml '%s' configuration is only supported on macOS right now", nw.Lima) | |||
| } | |||
| socketVMNetOk, err := nwCfg.IsDaemonInstalled(networks.SocketVMNet) | |||
| socketVMNetOk, err := config.IsDaemonInstalled(networks.SocketVMNet) | |||
There was a problem hiding this comment.
Yeah, I was unsure about it, but then decided to change it for consistency. Any time networks.LoadConfig() is called, the return value is stored in config. This made more sense to me than using different names in different places.
But I agree it is confusing inside qemu, which has its own Config type. How about calling it config inside the networks package and nwConfig everywhere else?
I'm also fine with using cfg and nwCfg, but again would want to use these names then consistently everywhere.
There was a problem hiding this comment.
nwCfg is more descriptive than config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because YAML is just the serialization format, and not what the data is used for.