Makefile: Improve rebuilding #2666
Draft
+63
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e signature with expected entitlements Signed-off-by: Norio Nomura <[email protected]>
…t/share/lima/lima-guestagent.Linux-%` Dependencies are defined using glob patterns: - `limactl`: `go.mod`, `./cmd/limactl/**/!(*_test.go)`, `./pkg/**/!(*_test.go)`. `vz.entitlements` will be added if darwin. - `lima-guestagent`: `go.mod`, `./cmd/lima-guestagent/**/!(*_test.go)`, and `./pkg/**/!(*_test.go)`. Those patterns are expanded by `bash` using `shopt`: `extglob`, `globstar`, and `nullglob`. Signed-off-by: Norio Nomura <[email protected]>
…l` binary is different from the current GO build variables. The variables being checked from `go version -m _output/bin/limactl`: - `GOVERSION` - `CGO*` - `GO*` - `-ldflags` are compared to output of `CGO_ENABLED=1 go env <variables>` and `$(LDFLAGS)`. If it differs, `limactl` will be force build. This is required to using `make artifact*`. Signed-off-by: Norio Nomura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to ensure proper rebuilding without using the
cleantarget by setting appropriate dependencies for each target.codesign: skip if_output/bin/limactl$(exe)has valid code signature with expected entitlements_output/bin/limactl$(exe): depends to source codes_output/share/lima/lima-guestagent.Linux-%: depends to source codeslimactl: forece rebuild if build variables are differs to built binarytemplates:manpages:_artifacts/lima-%.tar.gz:docsy: