-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make target for generating current arch config #2446
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
I agree with the opinion that a way to install only the native guest agent is needed, but I don’t quite understand why that would require |
I don’t necessarily want to block this PR, but since I don't understand the reasons for its implementation, I don’t have the criteria to judge its merits and therefore cannot evaluate the PR. |
The Kconfig is the configuration for the Makefile code, so enabling/disabling features is done there. A similar system is autoconf for automake, you might have seen a |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand what this PR is doing, but I still don’t understand why it’s necessary.
The only requirement was to be able to build Lima for the host architecture only... Building "minimal" does this, but it doesn't include any templates or helpers. Current workaround is doing the quiz:
i.e. same as what the new script does |
I’ve drafted a PR #2638 that refactors the Makefile, including a solution to that requirement. |
In other news, I updated kconfig-frontends so that it builds without warnings (on Linux or Mac). You do have to |
An improvement would be to rename it from "defconfig" to "nativeconfig" or somesuch. And to copy the non-arch fields from the |
Signed-off-by: Anders F Björklund <[email protected]>
f426a79
to
a74401b
Compare
make nativeconfig
The goal was to generate a config file, with only the current architecture.
Default config, empty
defconfig
:Could have used files:
As in the tool default:
ARCH=x86_64 kconfig-conf --defconfig Kconfig
arch/x86_64/config.mk
alternatively, defconfig:
ARCH=aarch64 kconfig-conf --defconfig Kconfig
arch/aarch64/config.mk
alternatively, defconfig:
The framework is overkill here, compared with kernel.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch