Allow compressing lima-guestagent with zstd #2427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
|
Example development config: CONFIG_GUESTAGENT_OS_LINUX=y
CONFIG_GUESTAGENT_ARCH_X8664=y
CONFIG_GUESTAGENT_ARCH_AARCH64=y
# CONFIG_GUESTAGENT_ARCH_ARMV7L is not set
# CONFIG_GUESTAGENT_ARCH_RISCV64 is not set
CONFIG_GUESTAGENT_COMPRESS_ZSTD=y
CONFIG_GUESTAGENT_COMPRESS_LEVEL=3Example release config: CONFIG_GUESTAGENT_OS_LINUX=y
CONFIG_GUESTAGENT_ARCH_X8664=y
CONFIG_GUESTAGENT_ARCH_AARCH64=y
CONFIG_GUESTAGENT_ARCH_ARMV7L=y
CONFIG_GUESTAGENT_ARCH_RISCV64=y
CONFIG_GUESTAGENT_COMPRESS_ZSTD=y
CONFIG_GUESTAGENT_COMPRESS_LEVEL=19 |
Signed-off-by: Anders F Björklund <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Can we just use gzip, to avoid requiring an extra dependency for downstream packages |
We could. It would be slower to decompress, but I don't think that it matters much here. |
Signed-off-by: Anders F Björklund <[email protected]>
|
This PR is mostly for evaluation, to compare the sizes/speeds of the different options...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2426
Compressing using highest level 19 takes forever (30 seconds), so should use something like 3 during development...
Everything is handled in the code, so that user doesn't need to have
zstdinstalled - neither on the host or in instance