Do guest template expansion for provisioning scripts #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
provision-template
branch
from
ba4e5d5
to
f62ef00
Compare
AkihiroSuda
reviewed
Jan 9, 2024
|
I think we could use
https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html It wouldn't fix the other provisioning scripts, though. |
jandubois
force-pushed
the
provision-template
branch
from
f62ef00
to
af41a18
Compare
The LIMA_CIDATA_* variables are not a supported API and can change without warning. Signed-off-by: Jan Dubois <[email protected]>
jandubois
force-pushed
the
provision-template
branch
from
af41a18
to
d8bb155
Compare
|
A nice thing about this change, is that we can do provisioning over ssh without implying cloud-init (cidata). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LIMA_CIDATA_* variables are not a supported API and can change without warning.
Fixes #2055