-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress the lima-guestagent in the installation directory #2426
Comments
Could make some different comparisons (size and time), using different compression formats and levels. |
Is this really worth the effort? Given that most Linux images are in the 300MB range? I could see adding additional |
This comment was marked as outdated.
This comment was marked as outdated.
The installation was indeed smaller, but it is probably not worth the complication.
If anything, could make it a boolean and stick with gzip only (smaller code addition)? -const Ext = ""
+const Ext = ".gz"
func Open(path string) (io.ReadCloser, error) {
- return os.Open(path)
+ reader, err := os.Open(path + Ext)
+ if err != nil {
+ return nil, err
+ }
+ return gzip.NewReader(reader)
} |
The "minimal" target does just this. _output/share/lima/lima-guestagent.Linux-$(shell uname -m | sed -e s/arm64/aarch64/) |
What I have wanted in the past is something like Obviously this is simple enough to add if/when I really need it. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Added a defconfig target to generate the arch config: #2446
Not sure if it is best with a script, or just two defconfig files ? CONFIG_GUESTAGENT_OS_LINUX=y
CONFIG_GUESTAGENT_OS_FREEBSD=n
CONFIG_GUESTAGENT_ARCH_X8664=y
CONFIG_GUESTAGENT_ARCH_AARCH64=y
CONFIG_GUESTAGENT_ARCH_ARMV7L=y
CONFIG_GUESTAGENT_ARCH_RISCV64=y |
"all" + gzip: (4 targets) 69M _output/ "minimal": (1 target) 64M _output/ |
Description
There are a lot of architectures, and not all of them are used...
We could compress them in the install, and decompress on host.
The on-disk lima installation goes from 175M to 68M, with gzip.
Note:
lima-guestagent
is still uncompressed, in thecidata.iso
The text was updated successfully, but these errors were encountered: