Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
What I changed:
tsconfig.json
target, package, etc fields to appropriate values for Node 16 as per the official documentation..js
extension where appropriate. This also means no more implicit index.js imports. 🐴cause
property declaration toNotFoundError
and changed the constructor code a little to make TypeScript happy. This part is slightly annoying, because Node 16 is ES2021 according to the above docs, but it also hasError.cause
and the two argument Error constructor from ES2022 since v16.9.0. TypeScript doesn't account for that, so I had to smack it with a wrench to get it working.As for why—
"node"
for tsconfig'smodule
andmoduleResolution
is deprecated in favor of"node16"
. Akte is currently incompatible with projects that use that setting. This PR fixes that, and you'll now get type errors if you try to use language features that aren't supported on Node 16 as an added bonus.Checklist: