"Move out-of-stock products to the end of a collection" - inner loop clobbers result from outer loop

[isaacbowen]

There's a bit in this task where we're traversing two graphql pagination loops at once. Both loops are currently using the variable result to store the graphql query results, which breaks pagination for the outer loop.

mechanic-tasks/docs/move-out-of-stock-products-to-the-end-of-a-collection/script.liquid

Lines 296 to 328 in b5bf9cb

	{% assign result = query | shopify %}
	{% if event.preview %}
	{% capture result_json %}
	{
	"data": {
	"product": {
	"variants": {
	"nodes": [
	{
	"id": "gid://shopify/ProductVariant/1234567890",
	"inventoryPolicy": "DENY",
	"inventoryQuantity": 0
	}
	]
	}
	}
	}
	}
	{% endcapture %}
	{% assign result = result_json | parse_json %}
	{% endif %}
	{% for variant in result.data.product.variants.nodes %}
	{% if variant.inventoryPolicy == "CONTINUE" or variant.inventoryQuantity > 0 %}
	{% assign has_in_stock_variant = true %}
	{% break %}
	{% endif %}
	{% endfor %}
	{% if result.data.products.variants.pageInfo.hasNextPage and has_in_stock_variant != true %}
	{% assign variants_cursor = result.data.products.variants.pageInfo.endCursor %}

[tekhaus]

Good catch, and a good reminder that there will likely be more loops in loops constructs in tasks as the 2K variants support approaches.