Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BumpFootprintExpirationOperation and RestoreFootprintOperation Responses. #486

Closed
overcat opened this issue Jul 20, 2023 · 2 comments
Assignees

Comments

@overcat
Copy link
Member

overcat commented Jul 20, 2023

What problem does your feature solve?

BumpFootprintExpirationOperation and RestoreFootprintOperation are newly introduced operations in the Protocol Soroban, and we need to add corresponding support for them.

What would you like to see?

  • Allow users to construct transactions that include these two operations.
  • The server needs to be able to parse these two operations correctly. (protocol)

What alternatives are there?

None

Estimated working hours: 6

@sreuland sreuland changed the title Add support for BumpFootprintExpirationOperation and RestoreFootprintOperation. Add support for BumpFootprintExpirationOperation and RestoreFootprintOperation Responses. Jul 27, 2023
@sreuland
Copy link
Contributor

I updated the title to narrow the scope to just supporting response models. The TransactionBuilder and TxSub aspects of these ops will need a new ticket created like 'Support TxSub for Invoke/Bump/Restore', and that will require soroban rpc integration and new flows for assembling transactions with preflight response data for setting tx footprint, fees. the js sdk, js-soroban-client, has gone through this enhancement for submitting tx's with these ops and preflighting, which can be used as a reference - stellar/js-soroban-client#108

@overcat overcat closed this as completed Jul 27, 2023
@overcat
Copy link
Member Author

overcat commented Aug 23, 2023

Implemented in #491.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants