Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epic] Protocol 20 SDK Support #470

Closed
2 of 12 tasks
mollykarcher opened this issue Mar 20, 2023 · 2 comments
Closed
2 of 12 tasks

[epic] Protocol 20 SDK Support #470

mollykarcher opened this issue Mar 20, 2023 · 2 comments

Comments

@mollykarcher
Copy link

mollykarcher commented Mar 20, 2023

This epic will be used to track the necessary changes to the SDK/Horizon API pursuant to Soroban / Protocol 20

minimal to support non-breaking compatibility with horizon API:

additional functionality for soroban specific contract usage(may move to a separate ticket)

  • Ability to submit Soroban/Protocol 20 Operations in Tx's, BumpFootprintExpirationOp, InvokeHostFunctionOp, RestoreFootprintOp
    • add support for using soroban rpc to use preflight which is required for the operations. Obtain tx Ext.SorobanData and InvokeHostFunction.Auth and the required miniumFee, to be included in the tx submitted. refer to js sdk implementation of preflight usage in prepareTransactionfor example - https://github.com/stellar/js-soroban-client/blob/main/src/server.ts#L526
  • java-stellar-sdk: add support for fees #479
  • add support for contract data ScVal conversions to sensible native java types, refer to js sdk's functional implementation of nativetoScVal and scValToNative for example and scope of conversions, i.e. all the different val types.
  • add an abstraction such as a pub/sub interface for getting contract events from soroban rpc as a stream.
  • add test coverage with mocked rpc interface.
  • add support for fetching contract storage key/value data, refer to js sdk implementation of getContractData()

follow the existing go p20/xdr sdk interface conventions.

@sydneynotthecity
Copy link

@sreuland to review and make more tickets for missing work

@sreuland
Copy link
Contributor

closing this epic, #490 will be used going forward for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants