-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower GLIBC requirements by using building linux natives on ubuntu 18.04 docker #23
base: master
Are you sure you want to change the base?
Conversation
3536e0c
to
5366bcc
Compare
@theofficialgman hi, just curious does the github action build still work on your side? I had recently problems on my end so I checked out your changes but still it doesn't seem to succeed building the Linux binaries. Here is a test fork of my project https://github.com/streamingdv/Jamepad/ Are you encountering the same issues in your fork branches? https://github.com/streamingdv/Jamepad/actions/runs/6625468273/job/17996650912 |
@theofficialgman okay fixed it, I think something has changed in the docker build image Fails now on the Gradle task... |
151e0a2
to
2f2d017
Compare
yeah strange. this is happening in jamepad master branch as well. I can reproduce on my x86_64 computer locally as well. there is no this is strange as nothing has changed at all that I can see. maybe gradle was previously able to use these files instead
|
Yeah I saw that, It's super strange, the make command passes now but the necessary output files weren't build. Nothing changed and I'm not sure what is causing that problem all of a sudden. I did not yet check on a real machine, does these files maybe get outputted to a different location than previously expected? |
@theofficialgman for testing purposes I just reverted the build action file to the original and disabled all Linux builds in it (only Windows x64/x86 enabled) and it seems that is working. (I removed the linux-libc-dev:i386 dependency as well) https://github.com/streamingdv/Jamepad/blob/master/.github/workflows/pushaction.yml So something different when make is building the Linux stuff. Not sure if it only affects Linux x86 maybe? Windows binaries can be successfully produced https://github.com/streamingdv/Jamepad/actions/runs/6629530789 |
4ab8bd4
to
27eb9ce
Compare
ok too me many hours but I finally realized what the actual issue is @streamingdv
the issue is the |
13b664f
to
1abd11a
Compare
@MrStahlfelge I have spent most of my day trying to bug test your CIs issue with the incorrect filepath issue. This PR is good for merging, I will leave it up to you to fix your CI |
Probably the fix is already suggested in #21 |
Nope. Read again. We have no issues installing dependencies. Issue is during linking #23 (comment) As I said. Fix your scripts as is (they don't work) and then you can come back to merging PRs. |
Build is fixed now |
1abd11a
to
0c8632f
Compare
@MrStahlfelge build failing in same place |
@theofficialgman I'm still not 100% sure what is causing the issue but I had this problem as well in my fork when I used your action script to build inside a docker container. If you are building the lib normally (without using a container) it will work and you will not run into this problem. |
still same linker error https://github.com/theofficialgman/Jamepad/actions/runs/8681588836/job/23804515917#step:39:74 |
The issue seems to be in
I don't know how/where these xmls are generated but I'm assuming that would be the cause. |
I think I found the cause. It seems to be the For Linux x32, for example:
|
Looks like the issue is that the underscore character is missing from the regex and therefore is not being matched and replaced. I'll create an issue for this. |
using ports.ubuntu.com and archive/security.ubuntu.com via specifying the arch variable in sources lists is the proper method. this will produce no apt update errors and will actually obtain all package info
alternative #22
closes #30