Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid separate numpy and cython install when building from source #148

Open
letmaik opened this issue Jun 27, 2021 · 0 comments
Open

Avoid separate numpy and cython install when building from source #148

letmaik opened this issue Jun 27, 2021 · 0 comments

Comments

@letmaik
Copy link
Owner

letmaik commented Jun 27, 2021

Related to #147.

The end goal is to be able to do pip install git+https://github.com/letmaik/[email protected] without installing numpy and cython in advance. This is mostly for Linux and will also work on macOS.

setuptools got more clever regarding cython: https://github.com/pypa/setuptools/blob/main/CHANGES.rst#180 But see also pypa/setuptools#1317.
However, this is not enough, as there's also this bit in setup.py: include_dirs += [numpy.get_include()]. I'm not sure yet how that can be deferred. Probably using pyproject.toml to declare build dependencies. The issue with that is that the numpy version should depend on the Python version to be as ABI compatible as possible, see also the GitHub Actions workflow. Maybe the requirements specifiers allow to express this. EDIT: There's https://pypi.org/project/oldest-supported-numpy/ which seems to be useful for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant