Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Test Topic #40

Open
ElDragonRojo opened this issue Aug 5, 2013 · 5 comments
Open

New Test Topic #40

ElDragonRojo opened this issue Aug 5, 2013 · 5 comments

Comments

@ElDragonRojo
Copy link
Contributor

This is a test topic, has been posted and edited from Lemacs. I have been unable to delete it, however. Maybe because @spllr added a comment and I can't delete his comments.

@spllr
Copy link
Contributor

spllr commented Aug 5, 2013

Super cool!

@ElDragonRojo
Copy link
Contributor Author

Just posting a response to prove that I still can.

@ElDragonRojo
Copy link
Contributor Author

Here is another response.

ElDragonRojo added a commit that referenced this issue Aug 5, 2013
_Creating, editing, and deleting issue and comments._

## GHStore

Creating, edit and deleting issues and comments are accomplished via two methods:

1. The over-arching `save<Class>` methods will add, edit, or delete, according to the current state of the object passed in as an argument.
2. The `delete<Class>` methods delete canceled new objects, then call through to the appropriate `save<Class>` method if necessary.

## LETalk

* Add a `topic` property to return the current issue’s title, regardless of whether the object is an issue or comment.

## GHManagedObject+LETalk

* Implement `plainTitle` method to return the current title including changes.
* Implement `topic` to return the current issue’s title regardless of whether the current talk is an issue or a comment.
  * The default behavior throws an exception and meant to be overridden by subclasses .

## GHManagedObject

* Move dictionary encoding for GitHub keys out of `dictionaryWithValuesForKeys:` into its own method.

## GHComment

* Expose commentID property
* Override `die` method
* Override `topic` method

## GHIssue

* Override `styledTitle` to experiment with delivering a different title for issue than for comments.
* Override `topic` method

## LETalkListController

* Remove the default accessory to save space.
* Set a custom disclosure accessory in an attempt to save space.

## LETalkViewController

* Reload the list on `viewWillAppear:` to ensure current changes are reflected in the table view.
* Enable the `CreateComment` segue.

## LEWorkViewController

* Implement `save` to send the current issue or comment to the server and pop back to the previous table.
* Save changes to the issue title.
* Toggle save and delete on comments based on whether there is a body.
  * If you want to delete the comment, delete the text, and the save button becomes delete.
  * Deleting comments seems to work.
* Toggle save and delete on issues based on whether there is a title set.
  * If you want to delete the issue, delete the title, and the save button becomes delete.
  * Deleting issues does not seem to work. I don’t know why. (Refs #40)
* Ensure the correct segment is selected when edit mode is toggled.
* Add a topic field for editing the current topic.
* When editing an issue, as opposed to a comment, move the topic from the prompt into the topic field.
  * This doesn’t work well and will probably be refactored away (Refs #31)

## iPhone UI

* Add some word bubbles in the table view cells.
* Give the app a nice bluish color to make the bubble pop.
* Adjust the layout to accommodate these changes and fix autolayout conflicts.
@spllr
Copy link
Contributor

spllr commented Aug 6, 2013

This is a test reply from an iPhone 4 without the s

@ElDragonRojo
Copy link
Contributor Author

This is a reply from the iPad version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants