Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong TravelMode parsing when building url. #117

Open
luis901101 opened this issue May 10, 2021 · 3 comments
Open

Wrong TravelMode parsing when building url. #117

luis901101 opened this issue May 10, 2021 · 3 comments

Comments

@luis901101
Copy link

The TravelMode enum parses its values to upper case to be able to parse from json response, but the thing is that the 'mode' query param to be used in the url request must be lower case.
Currently all requests whether GoogleMapsDirections or GoogleDistanceMatrix with a travel mode different than DRIVING is returning a response based in DRIVING travel mode which is Googles default.
@luis901101
Copy link
Author

A solution here PR-118

@kuamanet kuamanet mentioned this issue Jun 10, 2021
Closed
@2013612
Copy link

2013612 commented Aug 24, 2021

I have seen several pull requests are opened several months before to solve this serious issue but not yet merged.
May I know when would them be merged?

@scorpionate
Copy link

Anyone here? Facing same problem, #118 solves problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@2013612 @luis901101 @scorpionate