stackoverflow while formatting JSON

[kim-em]

Description

#eval (toString (toJson (Array.mkArray 70000 "string1"))).length

results in a stackoverflow. It is either in Std.Format.be, or some function that it is calling.

I'm uncertain if this is intrinsic to the design of be, or that some function has mistakenly become non-TR.

Context

This was reduced from the equational-theories project.

I did attempt to run lldb on this, but couldn't get a useful stacktrace out.

Versions

nightly-2024-09-30

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

[kim-em]

On the other hand

#eval (toJson (Array.mkArray 70000 "string1")).compress.length

is fine.

[digama0]

It is intrinsic to the formatter. The issue is that it is properly recursive, it has to deal with deep Format objects which are both left leaning and right leaning. The formatter could be modified to use an explicit stack, and I think it should; the non-tail-recursiveness of the formatter has caused many bug reports over the years.