-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-hook command not executed during initial dump #28
Comments
already fixed by #26 |
I see the following things not fixed by PR #26:
|
Do you agree that the post-hook command is now executed during initial dump for file?
|
I agree: the main issue is fixed. I will create an issue for "kv" not having an initial dump. I do not agree for your second point. There may have been a change in certs during initial dump -- we just don't know, because it is the initial dump. Whether there really is a change or not, the contents of the dump directory are still re-created. I therefore do not see a reason not to execute the post-hook, even when |
When running traefik-certs-dumper with
--watch
,--post-hook
andfile
, an initial dump happens when the program gets launched but the hook does not get executed.I see 2 solutions:
kv
behaves)Please note that at the moment,
file
andkv
do not behave the same way (see above). Whichever solution is chosen above should be reflected in bothfile
andkv
for consistency.The text was updated successfully, but these errors were encountered: