-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
:tzdata_release_updater terminating. 2nd argument: not a tuple #148
Comments
Yep, just saw the same after updating.
|
It seems this have been an issue which is marked as resolved, but isn't. From what I understood by a quick glance, the source data might have changed and causes issues. #143 |
@namxam Is this after upgrading to tzdata v1.1.2 ? |
Honestly I don't know, because the error is handled gracefully. I just noticed it in a project I am not working on often. I know I updated a few dependencies but I am not sure if tzdata was among it. I will check when I am back at my computer. |
Was greeted with the same error this morning, Upgrading from tzdata 1.1.1 => 1.1.2 fixed this for me. |
Thanks it saved me some time. |
I think the tzdata dep in our project is actually coming from here: https://github.com/bitwalker/timex/blob/c45b9a734074ac2a56355ec52ebf931b932223b7/mix.exs#L58. Our lock file says 1.1.1 so I'll update and see if that resolves it. |
This should be fixed in the v1.1.2 release: e63fc28 |
* Bump tzdata See: lau/tzdata#148 * Remove left-over :focus tags * Re-introduce test for #3820 It will catch the issue at least locally. But CI must likely be fixed to detect it. * Add temporary printf debugging (TM) to try to figure out the lack of failure on CI * Verify the destiny of the lock file (likely modified) * Implement a CI-reproduction for #3820 * Fix regression (#3820) Co-authored-by: Antoine Augusti <[email protected]> --------- Co-authored-by: Antoine Augusti <[email protected]>
|
You shouldn't be seeing this error as of 1.1.2. Check and make sure your mix.lock is showing |
Thanks @treshenry you are right. After writing the post we realised we actually never deployed the update in Production. False alarm. |
I did start off with my config as
config :tzdata, :data_dir, "priv/tzdata"
which also had this error on mix phx.server
and is now
The text was updated successfully, but these errors were encountered: