Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty Switching Searchable Filter Menus #6242

Open
mostafaznv opened this issue Feb 27, 2024 · 7 comments
Open

Difficulty Switching Searchable Filter Menus #6242

mostafaznv opened this issue Feb 27, 2024 · 7 comments
Labels
needs more info More information is required

Comments

@mostafaznv
Copy link

mostafaznv commented Feb 27, 2024

  • Laravel Version: 10.45.1
  • Nova Version: 4.32.15
  • PHP Version: 8.3.3
  • Database Driver & Version: Mysql 8.0.33
  • Operating System and Version: MacOS 14.2.1
  • Browser type and version: Google Chrome 121.0.6167.160

Hey everyone,

Apologies for reaching out again. Over the past month, I've opened three issues regarding the "Difficulty Switching Searchable Filter Menus" problem (first, second, third).
Firstly, thank you for your quick responses and the fixes released so far. However, the issue persists.

To recap, I've enabled the searchable and filterable flags on some BelongsTo fields.
While searching works fine on create/update pages, encountering at least two of these fields on the index page leads to difficulties when trying to use the filter menu. (For detailed explanations and recorded video demonstrations of the issue, please refer to the previous issues)


Some Investigations

Upon investigating the Nova source code, I found that commenting out this.$refs.input.focus() in the chooseSelected and choose methods of resources/js/components/Inputs/SearchInput.vue resolves the problem.
However, this disables the focus feature, reopening menus using keyup/keydown events, and the tab functionality.

Further investigation revealed that this issue arises when using SearchInput in nested dropdowns.


I hope this information is helpful. While I'm still working on finding a proper fix, I'm relatively new to Nova core.
Thanks for your understanding.

Related To:
#6189
#6199
#6227

Reproduction Repository:
https://github.com/mostafaznv/nova-searchable-filters-bug

Video:
link

@crynobone
Copy link
Member

The video shown is not based on the latest code. Please provide a new video showing the issue as I cannot replicate the "
difficulty" on the latest version after reverting Composition API (issues with dynamic refs) to Option API.

@crynobone crynobone added the needs more info More information is required label Feb 27, 2024
@mostafaznv
Copy link
Author

Bug

I've recorded a new video based on the latest code (v4.32.15).

video-1.mp4

Fix

And as you can see, after commenting the this.$refs.input.focus(), the filter box works as expected

video-2.mp4

screenshot

@mostafaznv
Copy link
Author

Is there anything else I should include in this issue?

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@mostafaznv
Copy link
Author

It's not a stale issue; I'm awaiting a reply from the Nova team.

@mostafaznv
Copy link
Author

mostafaznv commented Apr 27, 2024

Hi again,
Any updates? I've provided sufficient information to reproduce the bug. I've also noticed other issues reporting the same issue, but they were all automatically closed by a bot.

@crynobone

@stale stale bot removed the stale label Apr 27, 2024
@crynobone
Copy link
Member

What's can be fixed already has been fixed, still not confident that is solved and that's the reason it's still open at the moment. More reports and ideas are welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info More information is required
Projects
None yet
Development

No branches or pull requests

2 participants