Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment tests are still flaky #116

Open
TimMoore opened this issue Oct 21, 2019 · 2 comments
Open

Deployment tests are still flaky #116

TimMoore opened this issue Oct 21, 2019 · 2 comments
Labels
topic:build/tests

Comments

@TimMoore
Copy link

These seem to fail almost always on the first run, but usually pass on a re-run. I suspect a race condition.

We might be able to mitigate this by limiting to one concurrent job, at the expense of slowing down the happy path. WDYT?
@ignasi35
Copy link
Contributor

We might be able to mitigate this by limiting to one concurrent job, at the expense of slowing down the happy path. WDYT?

Sounds good to me. I haven't looked into the deployment tsts in a while so really hard to guess. Reducing the concurrent number of jobs is very cheap so let's test that, yeah.

@TimMoore
Copy link
Author

OK done. I also added daily cron builds for the 1.5.x and 1.6.x branches.

@ignasi35 ignasi35 mentioned this issue Jan 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:build/tests
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TimMoore @ignasi35