Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP keepalive timeout configuration to HTTP-serving components #2866

Open
achimnol opened this issue Sep 25, 2024 · 0 comments
Open

Add HTTP keepalive timeout configuration to HTTP-serving components #2866

achimnol opened this issue Sep 25, 2024 · 0 comments
Labels
area:infrastructure Infrastructure-related issues comp:appproxy Related to App Proxy component comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component comp:webserver Related to Web Server component effort:easy Need to understand only a specific region of codes (good first issue, easy). type:feature Add new features
Milestone
24.03

Comments

@achimnol
Copy link
Member

achimnol commented Sep 25, 2024 •
edited
Loading

The following components have HTTP-serving endpoints:

  • Manager
  • Storage Proxy
  • Web Server (aka Gateway)
  • WSProxy (aka App Proxy)

According to aio-libs/aiohttp#9285, we should set the HTTP keepalive timeout longer than the reverse-proxy if one is present to avoid races in the reverse-proxy.

aio-libs/aiohttp#9293 (backport of 9285) will be included in aiohttp release 3.11, and I think we should have also an explicit configuration knob to adjust this value as needed by the actual per-site setup.
@achimnol achimnol added type:feature Add new features area:infrastructure Infrastructure-related issues comp:manager Related to Manager component comp:webserver Related to Web Server component effort:easy Need to understand only a specific region of codes (good first issue, easy). comp:storage-proxy Related to Storage proxy component comp:appproxy Related to App Proxy component labels Sep 25, 2024
@achimnol achimnol added this to the 24.03 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:infrastructure Infrastructure-related issues comp:appproxy Related to App Proxy component comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component comp:webserver Related to Web Server component effort:easy Need to understand only a specific region of codes (good first issue, easy). type:feature Add new features
Projects
None yet
Milestone
24.03
Development

No branches or pull requests
1 participant
@achimnol