Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stability and visibility of session-concurrency checks #2746

Open
achimnol opened this issue Aug 21, 2024 · 1 comment
Open

Improve stability and visibility of session-concurrency checks #2746

achimnol opened this issue Aug 21, 2024 · 1 comment
Labels
comp:manager Related to Manager component type:bug Reports about that are not working type:enhance Enhance component, behavior, internals without user-facing features type:refactor Refactor codes or add tests. urgency:4 As soon as feasible, implementation is essential.
Milestone

Comments

@achimnol
Copy link
Member

achimnol commented Aug 21, 2024

Currently, we are implementing per-user limits of the maximum number of concurrently running sessions using counters: "compute" sessions and "SFTP" sessions. They are distinguished using a computed property is_private, which bases on the kernel_role attribute of sessions.

@achimnol achimnol added type:bug Reports about that are not working comp:manager Related to Manager component type:refactor Refactor codes or add tests. type:enhance Enhance component, behavior, internals without user-facing features urgency:4 As soon as feasible, implementation is essential. labels Aug 21, 2024
@achimnol achimnol added this to the 24.09 milestone Aug 21, 2024
@achimnol
Copy link
Member Author

During work on #2848 and review for #1587, I just found that the check_concurrency predicate does NOT satisfy the reentrancy assumption, meaning that it increments the concurrency-used counts whenever the scheduling is retried due to failure of other predicates.

This bug has been kind-of hidden because we have relied on the full recalculation upon session termination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component type:bug Reports about that are not working type:enhance Enhance component, behavior, internals without user-facing features type:refactor Refactor codes or add tests. urgency:4 As soon as feasible, implementation is essential.
Projects
None yet
Development

No branches or pull requests

1 participant