refactor: resource preset page #2656
Merged
+642
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
force-pushed
the
refactor/resource-preset-page
branch
from
ef84be4
to
0c4d3e9
Compare
github-actions
bot
added
area:ux
agatha197
force-pushed
the
refactor/resource-preset-page
branch
from
0c4d3e9
to
ab86c7a
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.34% (-0.08% 🔻) |
340/6367 |
| 🔴 | Branches | 4.83% (-0.08% 🔻) |
214/4433 |
| 🔴 | Functions | 3% (-0.06% 🔻) |
63/2099 |
| 🔴 | Lines | 5.24% (-0.08% 🔻) |
326/6220 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ResourcePresetList.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / ResourcePresetSettingModal.tsx |
0% | 0% | 0% | 0% |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 0c00d60
agatha197
force-pushed
the
refactor/resource-preset-page
branch
from
ab86c7a
to
2cb2e98
Compare
agatha197
added
effort:normal
Graphite App
agatha197
force-pushed
the
refactor/resource-preset-page
branch
from
2cb2e98
to
c126615
Compare
gahyuun
reviewed
Aug 29, 2024
agatha197
force-pushed
the
refactor/resource-preset-page
branch
2 times, most recently
from
c64148c
to
f730b33
Compare
agatha197
force-pushed
the
refactor/resource-preset-page
branch
from
f730b33
to
f2d9636
Compare
yomybaby
force-pushed
the
refactor/resource-preset-page
branch
from
f2d9636
to
4645e4e
Compare
Merge activity
|
> [!Note] > Unlike other components, the `requiredMark="optional"` is not included to form. Because it contains too many optional inputs. > <img width="300" alt="image" src="https://github.com/user-attachments/assets/12f4c0cf-3bbc-4b4b-bacb-94e2612d83b5"> resolves #2651 ### TL;DR Implemented a new ResourcePresetList, ResourcePresetSettingModal component and updated the EnvironmentPage to use it. ### What changed? - Added a new ResourcePresetList component to manage resource presets - Created a ResourcePresetSettingModal component for creating and editing resource presets - Updated the EnvironmentPage to use the new ResourcePresetList component - Adjusted padding and styling in ContainerRegistryList and KeypairResourcePolicyList - Added new translations for resource preset-related strings ### How to test? 1. Navigate to the Environment page 2. Select the "Resource Presets" tab 3. Verify that the new ResourcePresetList is displayed 4. Test creating, editing, and deleting resource presets 5. Confirm that the list updates correctly after each action 6. Check that the shared memory validation works as expected 7. Check that the new session is created successfully with the newly added resource preset. ### Why make this change? This change improves the user interface for managing resource presets, providing a more consistent and user-friendly experience. It also integrates better with the existing components and allows for easier maintenance and future enhancements of the resource preset functionality. ### Screenshots - List  - Modify  - Create  - Dark mode  - Validations  - Confirm to delete  --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [x] Minium required manager version: 23.09 - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
refactor/resource-preset-page
branch
from
4645e4e
to
0c00d60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Unlike other components, the
requiredMark="optional"is not included to form. Because it contains too many optional inputs.resolves #2651
TL;DR
Implemented a new ResourcePresetList, ResourcePresetSettingModal component and updated the EnvironmentPage to use it.
What changed?
How to test?
Why make this change?
This change improves the user interface for managing resource presets, providing a more consistent and user-friendly experience. It also integrates better with the existing components and allows for easier maintenance and future enhancements of the resource preset functionality.
Screenshots
List
Modify
Dark mode
Validations
Confirm to delete
Checklist: (if applicable)