Chapter 5: Callback on generate_authentication_token

[casimcdaniels]

In chapter five, there is a callback hook statement to generate an authentication token upon user creation

before_create :generate_authentication_token!

This however is flawed, as there is a uniqueness validation requirement. Since validations are performed before a user save is even considered, auth_token has a value of "" (not unique) and thus generate_authentication_token is never called!

The correct hook should be
before_validation :generate_authentication_token!

[kurenn]

I'll take note on that, for the next book version!

[casimcdaniels]

+1 for Breaking Bad

Also, take note shoulda matchers has issues with before_validation. For now in my project, I have left the test out since it always fails, but there may be a fix/monkeypatch for it.

[kurenn]

Yeah, probably, I''l leave this open as a reminder for the next book version! thanks for the fix