-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying custom build tags for the generated deepcopy files #871
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Sounds reasonable if it's doable without adding too much additional complexity (I'm not familiar with the current implementation) |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
/assign |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
It would be great if it was possible to specify custom Go build tags to be passed to deep copy generation, in the same way as it is currently possible to pass a custom header to be used, i.e
For the context - our Kubernetes custom resources live in a monorepo with our main application codebase, which is not Kubernetes specific. We build and run tests for various platforms, including plan9.
In our Kubernetes-specific code we need to import apimachinery library, but that contains code that cannot be built on plan9, i.e
syscall.Errno
here, so we exclude the Kubernetes-specific code from plan9 builds/tests with a!plan9
Go build tag.Currently there is no way how to pass build tags to the generated deepcopy files, so we end up using a sed script to modify these files after they have been generated- this is a bit hacky and also prevents us from being able to generate deepcopy files using
go generate
which would be our preferred way.I would be happy to PR a new flag to deepcopy generator for this.
The text was updated successfully, but these errors were encountered: