Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Flag TagUnmanagedNetworkResources does not work if network resources have internal aws tags #5120

Open
fiunchinho opened this issue Sep 12, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fiunchinho
Copy link
Contributor

/kind bug

What steps did you take and what happened:
We want to use already existing subnets. But we want to enable the TagUnmanagedNetworkResources feature flag, so that we can manage the subnet tags. But the subnets were created using CloudFormation, so they contain some tags of the form aws::cloudformation::*. When trying to add or delete tags of that form, the AWS API returns an error, because those are reserved/internal AWS tags.

InvalidParameterValue: Value ( aws:cloudformation:stack-name ) for parameter key is invalid. Tag keys starting with 'aws:' are reserved for internal use

What did you expect to happen:
When enabling the TagUnmanagedNetworkResources feature flag, VPC and subnets are reconciled without errors, and tags are applied normally.

Anything else you would like to add:
Would it be possible to change CAPA code so that it ignores tags that start with aws:?

Environment:

  • Cluster-api-provider-aws version: 2.5.2
  • Kubernetes version: (use kubectl version): 1.28
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 12, 2024
@dlipovetsky
Copy link
Contributor

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants