Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all created resources are tagged #5043

Open
UryDanko opened this issue Jul 2, 2024 · 3 comments
Open

Not all created resources are tagged #5043

UryDanko opened this issue Jul 2, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@UryDanko
Copy link

UryDanko commented Jul 2, 2024

/kind bug

What steps did you take and what happened:

I created a cluster with a node pool and a few nodes in it by using AWSManagedMachinePool and MachinePool.
Also I set additionalTags with some tags in it.

What did you expect to happen:
I'd expect that all created resources would have the same set of tags.
However, some of them are tagged with the additionalTags, and some are not.
For example:
tagged:
Node Pool
IAM role attached to a node (EC2 instance)
ASG backed the node pool

not tagged:
node (EC2 instance)
launch template, attached to the ASG
SG attached to the EC2
EBS volume attached to EC2 (it has no tags at all)

Anything else you would like to add:
Resources, mentioned above usually are tagged but some of them don't have additionalTags

Environment:

  • Cluster-api-provider-aws version: 2.5.2
  • Kubernetes version: (use kubectl version): 1.29
  • Cluster-api-operator version: 0.11.0
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority labels Jul 2, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 2, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@UryDanko
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants